Helixhorned, on 03 June 2013 - 07:44 AM, said:
Nope, they are not. See setgamemode() in engine.c.
I should mention that this is orthogonal to the question of whether xdim or xdim-1 is the right value to provide to
rotatesprite and friends to denote the right border (analogously, the lower border for ydim). The answer to this one is that it doesn't matter for the classic renderer. In dorotatesprite(), we have:
// bound clipping rectangle to screen
if (cx1 < 0) cx1 = 0;
if (cy1 < 0) cy1 = 0;
if (cx2 > xres-1) cx2 = xres-1;
if (cy2 > yres-1) cy2 = yres-1;
(xres is the same as xdim as far as I can see). So even if the "correct" way is to pass xdim-1 (because the bounds denote a both-side inclusive range of pixel center coordinates), passing xdim does the same and saves a few keystrokes.
However, in the Polymodes' rotatesprite, polymost_rotatesprite(), it seems that we don't clamp the bounds to the screen size, producing slightly different results for xdim-1 and xdim. This is irritating and IMO we should take over the behavior from classic.
Fox, on 03 June 2013 - 08:23 AM, said:
Well, that's something that changed recently.
The way I see it is that nothing has changed on the implementation side, but that Hendricks merely edited the wiki to promote the most "proper" practice.