[r8620] E1L1 dumpster fire does not cause burn damage when stood on

Doom64hunter

#1 Posted 10 February 2020 - 10:50 AM

Credit goes to mjr4077au on ZDoom (Raze) for finding and bisecting this.

When standing in the burning E1L1 dumpster, the player takes no fire damage as of r8620. This was introduced in r8001 and the call to 'A_GetZLimits()' is causing it.
Since that commit, said call has moved to line 1523 of 'source/duke3d/src/game.cpp', but still appears to be the source of the problem.

This post has been edited by Doom64hunter: 10 February 2020 - 11:47 AM

Mark

#2 Posted 10 February 2020 - 12:32 PM

Is that the only flame that doesn't burn? I have 8620 installed in my projects for testing. HHR and Suburbs use flame sprites 2271 and 2311. Both burn the player.

I haven't tried vanilla game yet.

EDIT: The same 2311 flame sprite at the dumpster doesn't burn player in vanilla game. Odd. ( tested with HRP and Polymer )

This post has been edited by Mark: 10 February 2020 - 12:38 PM

Doom64hunter

#3 Posted 10 February 2020 - 01:05 PM

Mark, on 10 February 2020 - 12:32 PM, said:

I've got a feeling that this is something very specific to the map geometry, the flame sprite itself is fine.

Mark

#4 Posted 10 February 2020 - 01:56 PM

It reminds me of another glitch that just seemed about map geo. Do you remember when it was reported that one of the seat benches in the cinema was glitching when viewed from certain angles? It was a simple construct of 2 sectors. I deleted and rebuilt those 2 sectors and the problem went away. I don't recall if that ever got figured out and fixed. I'm guessing it did because I haven't heard it mentioned in a while.

This post has been edited by Mark: 10 February 2020 - 01:59 PM

Kyanos

#5 Posted 10 February 2020 - 04:15 PM

Doom64hunter, on 10 February 2020 - 01:05 PM, said:

I've got a feeling that this is something very specific to the map geometry, the flame sprite itself is fine.

If the boxes get deleted the fire works right again.

Falling fire is glitched too, but I'm not sure how often that scenerio comes up in the game.

Basically, falling fire I can duck under without getting hurt. Like the crack in the wall of the theatre/arcade e1l1. That goes way back I've yet to disect it.

added: That one fire sprite in the theatre crack never worked all the way back to dos. Falling fire is glitchy in every revision including jfduke/megaton back to dos, but it behaves worse now than ever.

edit2: example, that falling fire in the theatre/arcade crack no longer falls.

This post has been edited by Photonic: 10 February 2020 - 06:53 PM