[thisbecasper]

Trooper Dan, on 20 October 2017 - 10:02 AM, said:

Yeah, "ifdead" does work like while dead, so any "ifdead" condition that triggers the ammo bonus should be nested inside an "ifhitweapon" check, to insure that only the killing blow is counted. This means you should make a state that does the bonusing and call it only after appropriate "ifdead" instances.

I can see the point in making states here, although I simply can't make it to work...

state updatevalue
{
	getplayer[THISACTOR].wackedbyactor killer
    getactor[killer].picnum tempkiller
    ifvare tempkiller APLAYER
    {
    		ifhitweapon
    		{
    			addvar rpgsammo 10
    		}
    		getactor[killer].yvel tempkiller
    		setplayer[tempkiller].max_ammo_amount RPG_WEAPON rpgsammo
    }
}
ends

---

 ifdead
  {
    state updatevalue

I am drawing the rpgsammo through digitalnumberz so I can keep track of it as I'm killing players and dying to players. No matter what it wont increment, and it also just sets the maxammo to whatever the value the variable was declared with in the first place. Actually I'm doubting that I'm using ifhitweapon correct, because when I place the two lines below into the if-statement together with "addvar rpgsammo 10", it wont even set maxammoamount

[Hendricks266]

The ifhitweapon/ifdead structure should look like this:

state updatevalue
    getplayer[THISACTOR].wackedbyactor killer
    getactor[killer].picnum tempkiller
    ifvare tempkiller APLAYER
    {
                addvar rpgsammo 10
                getactor[killer].yvel tempkiller
                setplayer[tempkiller].max_ammo_amount RPG_WEAPON rpgsammo
    }
ends

ifhitweapon
{
  ifdead
  {
    state updatevalue

If this doesn't work, there may be something that prevents setting max_ammo_amount from working, and in thta case I'll look into it.

[thisbecasper]

Hendricks266, on 20 October 2017 - 02:58 PM, said:

The ifhitweapon/ifdead structure should look like this:

state updatevalue
    getplayer[THISACTOR].wackedbyactor killer
    getactor[killer].picnum tempkiller
    ifvare tempkiller APLAYER
    {
                addvar rpgsammo 10
                getactor[killer].yvel tempkiller
                setplayer[tempkiller].max_ammo_amount RPG_WEAPON rpgsammo
    }
ends

ifhitweapon
{
  ifdead
  {
    state updatevalue

If this doesn't work, there may be something that prevents setting max_ammo_amount from working, and in thta case I'll look into it.

Now I've tried what you suggested, and thanks for that btw!, but it still won't work. It sets the maxammo to the variable plus the value you add, in this case 10 - but only once. I'm drawing the value of the var rpgsammo on my screen and it doesn't update when 10 is added. It remains whatever I declare it to. Summing up: After a kill the actual max_ammo_amount and rpgsammo doesn't match, and the max_ammo_amount wont increment on kills past the first one.

[Hendricks266]

state updatevalue
    getplayer[THISACTOR].wackedbyactor killer
    getactor[killer].picnum tempkiller
    ifvare tempkiller APLAYER
    {
                getactor[killer].yvel tempkiller
                getplayer[tempkiller].max_ammo_amount RPG_WEAPON temp
                addvar temp 10
                setplayer[tempkiller].max_ammo_amount RPG_WEAPON temp
    }
ends

[thisbecasper]

Hendricks266, on 20 October 2017 - 04:44 PM, said:

state updatevalue
    getplayer[THISACTOR].wackedbyactor killer
    getactor[killer].picnum tempkiller
    ifvare tempkiller APLAYER
    {
                getactor[killer].yvel tempkiller
                getplayer[tempkiller].max_ammo_amount RPG_WEAPON temp
                addvar temp 10
                setplayer[tempkiller].max_ammo_amount RPG_WEAPON temp
    }
ends

I only got it to work when put under ifwasweapon RPG - I don't know how to make it work if put under ifhitweapon under ifdead or reverse. Anyway - Something comepletely different: Is it possible to draw an ingame menu with options that perform lines of code when pressed when chosen, and if it is, is it difficult? I'm thinking of an upgrade system, but you'll have to use menu to upgrade the weapons.

[thisbecasper]

Does somebody know how to get around the instant freeze of the game when the hp goes to -1 in the case of the player getting frozen.

onevent EVENT_DISPLAYREST
  	//Healthbar
  	getactor[THISACTOR].extra health
  	getplayer[THISACTOR].MAX_PLAYER_HEALTH maxhp
  	setvar xvar 0

  	whilevarn maxhp 0
  	{
  		rotatesprite xvar 185 65536 0 3163 0 0 49 0 0 xdim ydim 
    	addvar xvar 1 // move to the right
    	subvar maxhp 1 // next hitpoint
  	}

  	setvar xvar 0
  	setvar yvar 100

  	whilevarn health 0
  	{ 
    	ifvarg health 100
  		{
  			rotatesprite yvar 185 65536 0 3163 0 2 16 0 0 xdim ydim // draws atomic health
   			addvar yvar 1 // move to the right
    		subvar health 1 // next hitpoint
  		}
  		else
  		{
  			rotatesprite xvar 185 65536 0 3163 0 0 16 0 0 xdim ydim // draws regular health
    		addvar xvar 1 // move to the right
    		subvar health 1 // next hitpoint
  		}
   	}
	
endevent

This code crashes the game unfortunately. There has to be fix for this...

Quote

Anyway - Something comepletely different: Is it possible to draw an ingame menu with options that perform lines of code when pressed when chosen, and if it is, is it difficult? I'm thinking of an upgrade system, but you'll have to use menu to upgrade the weapons.

Nvm, think I've found something on it now.

Is there a way to achieve the ID of the player you are hitting, or even better, looking at?

[Perro Seco]

Trooper Dan, on 14 October 2017 - 03:22 PM, said:

You could try forcing over_shoulder_on to 1. Normally this would also change the camera position, but since you are already forcing a camera position as well, it might do the job. Don't forget to restore it to the previous value when camera viewing ends. EDIT: To be clear, this isn't necessary the best solution, but I don't remember what is going on with the player sprite that makes it invisible. It might be a tsprite thing.

Thanks a lot for your help, that almost did the trick, but now the player is transparent, just like when F7 view is activated. I can change its cstat, but looks like the game adds the transparency effect over that value...

Also, when playing demos using the cam, I get the "out of sync" warning. Reading in the wiki, looks like this is caused by manipulation of constantly updated gamevars, but the only gamevars I manipulated here were the ones from the above mentioned tutorial. Would that cause a sync problem?

[thisbecasper]

thisbecasper, on 21 October 2017 - 12:20 PM, said:

Does somebody know how to get around the instant freeze of the game when the hp goes to -1 in the case of the player getting frozen.

onevent EVENT_DISPLAYREST
  	//Healthbar
  	getactor[THISACTOR].extra health
  	getplayer[THISACTOR].MAX_PLAYER_HEALTH maxhp
  	setvar xvar 0

  	whilevarn maxhp 0
  	{
  		rotatesprite xvar 185 65536 0 3163 0 0 49 0 0 xdim ydim 
    	addvar xvar 1 // move to the right
    	subvar maxhp 1 // next hitpoint
  	}

  	setvar xvar 0
  	setvar yvar 100

  	whilevarn health 0
  	{ 
    	ifvarg health 100
  		{
  			rotatesprite yvar 185 65536 0 3163 0 2 16 0 0 xdim ydim // draws atomic health
   			addvar yvar 1 // move to the right
    		subvar health 1 // next hitpoint
  		}
  		else
  		{
  			rotatesprite xvar 185 65536 0 3163 0 0 16 0 0 xdim ydim // draws regular health
    		addvar xvar 1 // move to the right
    		subvar health 1 // next hitpoint
  		}
   	}
	
endevent

Fixed.

Now my only questions are: How do you alter another player's gamevar. And is there a way to achieve the ID of the player you are hitting, or even better, looking at?

[Hendricks266]

gamevar myvar 0 1

getplayervar[index].myvar
setplayervar[index].myvar

[thisbecasper]

Hendricks266, on 22 October 2017 - 12:52 AM, said:

gamevar myvar 0 1

getplayervar[index].myvar
setplayervar[index].myvar

gamevar killer 0 2
gamevar tempkiller 0 2
gamevar temprpg 0 1

state updatevalue
    getplayer[THISACTOR].wackedbyactor killer
    getactor[killer].picnum tempkiller
    ifvare tempkiller APLAYER
    {
                getactor[killer].yvel tempkiller
                getplayervar[tempkiller].temprpg
                addvar temprpg 7
                setplayervar[tempkiller].temprpg
    }
ends    

actor APLAYER MAXPLAYERHEALTH PSTAND 0 0

	getplayer[THISACTOR].max_ammo_amount RPG_WEAPON temprpg

"GAME.CON:3582: error: symbol `setplayervar' is a keyword."

[Mblackwell]

gamevar killer 0 2
gamevar tempkiller 0 2
gamevar temprpg 0 1
gamevar temp 0 0

state updatevalue
    getplayer[THISACTOR].wackedbyactor killer
    getactor[killer].picnum tempkiller
    ifvare tempkiller APLAYER
    {
                getactor[killer].yvel tempkiller
                getplayervar[tempkiller].temprpg temp
                addvar temp 7
                setplayervar[tempkiller].temprpg temp
    }
ends    

actor APLAYER MAXPLAYERHEALTH PSTAND 0 0

	getplayer[THISACTOR].max_ammo_amount RPG_WEAPON temprpg

[thisbecasper]

Mblackwell, on 22 October 2017 - 09:38 AM, said:

gamevar killer 0 2
gamevar tempkiller 0 2
gamevar temprpg 0 1
gamevar temp 0 0

state updatevalue
    getplayer[THISACTOR].wackedbyactor killer
    getactor[killer].picnum tempkiller
    ifvare tempkiller APLAYER
    {
                getactor[killer].yvel tempkiller
                getplayervar[tempkiller].temprpg temp
                addvar temp 7
                setplayervar[tempkiller].temprpg temp
    }
ends    

actor APLAYER MAXPLAYERHEALTH PSTAND 0 0

	getplayer[THISACTOR].max_ammo_amount RPG_WEAPON temprpg

Now I think I've got it to work finally - thanks guys!

However, I still don't know how to obtain ID of a player unless the player kills you... I want to display damage dealt to the person and/or the health bar of the person they are looking at or last hitted - But I don't know how to get a call to the proper player... Am I missing something obvious here?

[Hendricks266]

http://wiki.eduke32.com/wiki/htowner

This will give you the sprite id. If the picnum is APLAYER, then you can get the player id from .yvel.

[thisbecasper]

Hendricks266, on 22 October 2017 - 01:08 PM, said:

http://wiki.eduke32.com/wiki/htowner

This will give you the sprite id. If the picnum is APLAYER, then you can get the player id from .yvel.

omg thank you - been looking for this for so long. Dumb that I haven't stumpled upon it. Thank you.

onevent EVENT_GAME
{
	getactor[THISACTOR].htowner killer
	ifvare killer APLAYER
	{
		getactor[THISACTOR].extra hp
		getactor[killer].yvel tempkiller
		setplayervar[tempkiller].targethp hp
	}

(...)

If I shoot at someone, targethp won't register - it's 0 all the time.
I've tried writing it under actor APLAYER, and as a state, no luck.

[thisbecasper]

Is there a way to have to seperate counters that dont reset eachother upoc resetcounter on one of them? It's because I have a healthregen system, which adds 1 health every 15th code cycle, and at the same time I have some code that adds 1 ammo to the shotgun every 23rd code cycle. There are not written in the same state, but of course the second won't ever get to add ammo to the shotgun.. workaround?

[Danukem]

Just make your own counters using per-player gamevars.

[thisbecasper]

Trooper Dan, on 22 October 2017 - 11:22 PM, said:

Just make your own counters using per-player gamevars.

Oh, yeah of course. Now I finally understand the way add works... I've tried to add something under event_game, and the number shoots into the air, so I was afraid to add something constantly. Got to understand it now, thanks!

[Danukem]

thisbecasper, on 23 October 2017 - 01:35 AM, said:

Oh, yeah of course. Now I finally understand the way add works... I've tried to add something under event_game, and the number shoots into the air, so I was afraid to add something constantly. Got to understand it now, thanks!

All the code in EVENT_GAME is executed by every single sprite in the game once per tic. So if every sprite increments a per-player var, then of course it will get very high very fast (and more or less randomly). What you have to do is either increment the var in the actor APLAYER code, or if you are going to use EVENT_GAME, then make sure the code is only executed by players (use the condition ifactor APLAYER or something equivalent).

[thisbecasper]

I'm still trying desperately to draw the amount of hp the opponent has to the screen. Just hitting the opponent should be enough to get opponents hp shown, but no luck whatsoever... any alternative suggestions?

[Hendricks266]

Do you want the HP to stay on screen until you die, or do you want it to time out?

Do you want it to continue to show an updated HP amount if the target takes damage from other sources, or do you want it to show the last known HP amount of the player when you hit them?

What do you want to happen if you hit one player, then hit another player while the first HP is still displaying?

What do you want to happen if you hit more than one player at the same time, such as with anything that has a hitradius?

[thisbecasper]

Hendricks266, on 24 October 2017 - 11:39 AM, said:

Do you want the HP to stay on screen until you die, or do you want it to time out?

Do you want it to continue to show an updated HP amount if the target takes damage from other sources, or do you want it to show the last known HP amount of the player when you hit them?

What do you want to happen if you hit one player, then hit another player while the first HP is still displaying?

What do you want to happen if you hit more than one player at the same time, such as with anything that has a hitradius?

Thank you for asking!
1) I want to have the hp bar/or number (its all about getting the opponents .extra really), be displayed for 3 seconds after you've inflicted dmg.

2) Im right inbetween these two... possibly constant updated, so it displays loss of health from other sources.

3) It should only display the "last" person you hit.

4) If you hit two, show random I guess (or the one with the least hp).

And while we are at it, I'm thinking to substitute the amount of hp you've dealt as dmg with a sub-bar of different color. So if the person had 90 hp, and I hit for 37, the bar would show me 90 units - 53 for current hp and 37 for dmg dealt while the bar is showing. Then if I hit again for 10 the bar would still show 90 units... If this idea goes through, I think I'll choose the other option for question 2).

[thisbecasper]

How come

state healthregen
	addvar healthregencounter 1
	ifvarg healthregencounter 30
	{
		addphealth 1
		setvar healthregencounter 0
	}
ends

state pistolregen
	ifvare pweapon PISTOL_WEAPON
	{
		ifvare currammo 72
		{
			setvar weaponregencounter 0
		}
		else
		{
			addvar weaponregencounter 1
			ifvarg weaponregencounter 14
			{
				addammo PISTOL_WEAPON 1
				setvar weaponregencounter 0
			}
		}
	}
ends

state tripbombregen
	ifvare currtripbombammo 10
	{
		setvar tripbombregencounter 0
	}
	else
	{
		addvar tripbombregencounter 1
		ifvarg tripbombregencounter 250
		{
			addammo TRIPBOMB_WEAPON 1
			setvar tripbombregencounter 0
		}
	}
ends

this work, but if I change

state pistolregen
	ifvare pweapon PISTOL_WEAPON

to

state pistolregen
	ifvare roundweapon PISTOL_WEAPON

where roundweapon is set to a value in EVENT_GAME, it doesn't?

I'm trying to have currentweapon ammo regenerate together with health and tripmine ammo (but if pweapon = tripmine_weapon, it should regenerate a weapon corresponding to roundweapon. You can only have one weapon at all time, and then tripmines as side arms basically). It works with the last change, but then I won't take dmg from the tripmine until I don't have the tripmine_weapon equipped... Basically I can delay dmg from the tripmines if I'm currently having the tripmine weapon in my hands - as soon as I change weapon, the dmg hits me and the screen flashed red and so on. It's like it doesn't like to have 3 active gamevars counters at the same while holding the tripmine time but I really don't know...

[Danukem]

thisbecasper, on 25 October 2017 - 02:24 PM, said:

where roundweapon is set to a value in EVENT_GAME, it doesn't?

You must be setting it to a different value in EVENT_GAME. Without seeing the code, I can only guess that it is being set to several different values by different sprites, and it ends up being a different value from the one you want.

[thisbecasper]

Trooper Dan, on 25 October 2017 - 07:01 PM, said:

You must be setting it to a different value in EVENT_GAME. Without seeing the code, I can only guess that it is being set to several different values by different sprites, and it ends up being a different value from the one you want.

The roundweapon var is a perplayer var determined by the difference between frag and fraggedself, which are also perplayer vars. If you between 0 and 2 kills your roundweapon is pistol, if you have between 3 and 5 kills your roundweapon is set to the shotgun, so in my head it should work - The counters are working fine, and as they should, but it's the tripmine that wont work properly in action, which is weird, and I can't see the link between using a number to dertermine which weapon to regenerate and the tripmine not working properly..

[Danukem]

Typically, just thinking about a problem is not enough to debug it. If I had a dollar for every time something wasn't working right with my code and the behavior "didn't make sense" I would be able to buy a house. You have to follow the flow of code step by step, starting from where you know it is working correctly and then verify each step after that until you find where it is breaking. Don't forget you can use the addlogvar command to help you.

[thisbecasper]

I HAVE FOUND THE THING THAT CAUSED IT - hallelujah - still doesn't makes sense to me though, but I've found a workaround. Orignally I had made sure the counters were set to 0 if the weapon's ammo amount was at maxammo, so that it wouldn't count to infinity essentially. The problem was that my method took currentammo as a var and and not the currentammo on the roundweapon - long story short -> Weird behavior of the tripmines was caused by counters going wild.

[thisbecasper]

Is there no way to be able to know how much hp the opponents has, by either hitting or looking at them? - I've tried so many thinks now, do you guys know if it has been achieved before?

[Zaxtor]

You mean like the condition of the monster etc?
I'm sure there maybe a code somewhere to show the hp number and or displaying above its head.
Or little bar like most modern games have.

My mod for bosses has health bar. (50 lines in bar)

[Danukem]

thisbecasper, on 27 October 2017 - 02:08 PM, said:

do you guys know if it has been achieved before?

Yes. I have this feature in WGR2 for displaying the health bars of bosses on the player's hud. Also in DukePlus, I have an option for displaying a health bar above the head of each enemy. Feel free to borrow whatever code you want, but I don't have time to write a tutorial.

One thing you should realize is that there are many different ways of implementing this type of feature. The health of an actor is always the value of .extra, but you have many choices for displaying it and when to display it. If you are going to show only one enemy's health amount at a time, then there are several conditions you should consider, and some logic in assessing them, including: (1) line of sight to the enemy, (2) distance to the enemy, (3) whether the enemy was the most recent actor to hurt the player, (4) whether you are facing the enemy, even if line of sight is momentarily broken

[thisbecasper]

Trooper Dan, on 27 October 2017 - 07:40 PM, said:

Yes. I have this feature in WGR2 for displaying the health bars of bosses on the player's hud. Also in DukePlus, I have an option for displaying a health bar above the head of each enemy. Feel free to borrow whatever code you want, but I don't have time to write a tutorial.

One thing you should realize is that there are many different ways of implementing this type of feature. The health of an actor is always the value of .extra, but you have many choices for displaying it and when to display it. If you are going to show only one enemy's health amount at a time, then there are several conditions you should consider, and some logic in assessing them, including: (1) line of sight to the enemy, (2) distance to the enemy, (3) whether the enemy was the most recent actor to hurt the player, (4) whether you are facing the enemy, even if line of sight is momentarily broken

I would have no trouble in handling the data once I've got them, It's just a matter of how I can view another aplayer actor's gamevar's value in realtime (once I've got the ID of the player I'm hitting, or whatever) - I'm working on some multiplayer stuff and I'm using the eduke32-oldmp build, idk if that's make a difference. I will try look at your code and see if it works the same way for players, thanks!