Shadow Warrior - "New Episode" - Duke4.net Forums

44 Pages
« First
←
34
35
36
37
38
→
Last »

You cannot start a new topic
You cannot reply to this topic

Shadow Warrior - "New Episode"

icecoldduke

#1051 Posted 19 July 2017 - 08:39 PM

Hendricks266, on 19 July 2017 - 08:16 PM, said:

Are you really sure there is fuckage in the audiolib? Do these bugs happen with JFSW?

Here is a question for you. In the DOS version of Shadow Warrior, if there are no sounds playing, and I play a 3d sound, the sound system should put that sound on channel 0. If play another sound, after the previous sound completes, would the sound system put the new audio on channel 1 or 0?.

This post has been edited by icecoldduke: 19 July 2017 - 08:40 PM

Hendricks266

Weaponized Autism

#1052 Posted 19 July 2017 - 08:40 PM

https://winworldpc.c.../watcom-c-c/106

icecoldduke

#1053 Posted 19 July 2017 - 08:58 PM

I need to do some more testing with my audiolib findings before I report anything. There is definitely something going on, which is causing problems in my multithreading code, the problem is not 100% confident on where its coming from yet. SDL_Mixer is definetly fucking with classic and Polymost somehow in my branch. I just don't know how yet.

Hendricks, in my branch I plan on replacing all FX_SoundActive calls with a custom SoundActive function I created that tests if the channel playing the audio is playing the audio the code is expecting. My sound system has been using this for awhile, but there are extra calls FX_SoundActive calls through out the SW codebase. Callbackval is set by FX_Play3D or FX_SoundPlay with the value of the sound id passed in PlaySound. Do you see a problem with this?

//
// SW_SoundIsActive
//
bool SW_SoundIsActive(int handle, int snum)
{
	return FX_SoundActive(handle) && FX_GetVoiceCallback(handle) == snum;
}

Where FX_GetVoiceCallback calls MV_GetCallback

int32_t MV_GetCallback(int32_t handle)
{
	VoiceNode *voice = MV_GetVoice(handle);

	if (voice == NULL)
		return MV_Error;

	int32_t callbackval = voice->callbackval;

	return callbackval;
}

So in DoZillaMove:

if (!FX_SoundActive(handle))
{
    ...
}

Would turn into

if (!SW_SoundIsActive(handle, DIGI_Z16004.GetVar()))
{
     ...
}

This post has been edited by icecoldduke: 19 July 2017 - 09:02 PM

Hendricks266

Weaponized Autism

#1054 Posted 19 July 2017 - 09:57 PM

If SDL_mixer is really affecting the renderers by some unimaginable process, you'd most likely be able to find out using valgrind or ASan.

Hendricks266

Weaponized Autism

#1055 Posted 19 July 2017 - 10:02 PM

<terminx> maybe he just needs to use a mutex with the audio handling stuff
<terminx> the audio code uses a callback function but it runs from a separate audio thread
<terminx> older versions of eduke32 had all kinds of problems with audio before I figured that out

icecoldduke

#1056 Posted 20 July 2017 - 04:46 AM

Hendricks266, on 19 July 2017 - 10:02 PM, said:

If SDL_mixer is really affecting the renderers by some unimaginable process, you'd most likely be able to find out using valgrind or ASan.

Thanks for that info :thumbsup:

Hendricks266, on 19 July 2017 - 10:02 PM, said:

<terminx> maybe he just needs to use a mutex with the audio handling stuff

I think you might be right, I missed the DisableInterrupts and RestoreInterrupts functions when porting over code to Shadow Warrior, I'll do that tonight when I get home.

icecoldduke

#1057 Posted 21 July 2017 - 04:19 AM

NEW BINARY RELEASE:

https://github.com/j..._july212017.rar

Whats New:

Polymost and Classic should now work. I had to disable compile time optimizations to get this to work. This is a temporary solution while I try and work out the issue.

The issue will remain as is for now. I wanted to fix the build so people can use Polymost/Classic. I'm switching over to some render work.

This post has been edited by icecoldduke: 21 July 2017 - 04:23 AM

Hendricks266

Weaponized Autism

#1058 Posted 21 July 2017 - 07:21 AM

Wait a minute.

Go into compat.h and change "typedef intptr_t ssize_t;" to "typedef int32_t ssize_t;", then see if building with optimizations works again.

icecoldduke

#1059 Posted 21 July 2017 - 07:25 AM

Hendricks266, on 21 July 2017 - 07:21 AM, said:

Go into compat.h and change "typedef intptr_t ssize_t;" to "typedef int32_t ssize_t;", then see if building with optimizations works again.

I'll do that as soon as I get home tonight.

TON

#1060 Posted 21 July 2017 - 08:10 AM

It works

Hendricks266 fixed the problem

Hendricks266

Weaponized Autism

#1061 Posted 21 July 2017 - 08:15 AM

TX and I encountered this bug when I visited him. We suspect it is a VS compiler bug.

Could you try replacing the line in question with this? Our current workaround (what I pasted above) fixes correctness but it has performance drawbacks.

# if defined _M_AMD64 || defined _M_ARM64 || defined _M_X64 || defined _WIN64
typedef int64_t ssize_t;
# else
typedef int32_t ssize_t;
# endif

icecoldduke

#1062 Posted 21 July 2017 - 08:24 AM

TON, on 21 July 2017 - 08:10 AM, said:

Hendricks266 fixed the problem

So to confirm you verified the fix?

Hendricks266, on 21 July 2017 - 08:15 AM, said:

...

That article was a interesting read, I fucking hate VS compiler bugs :/.

TON

#1063 Posted 21 July 2017 - 08:31 AM

icecoldduke, on 21 July 2017 - 08:24 AM, said:

So to confirm you verified the fix?

Yes

TON

#1064 Posted 21 July 2017 - 08:35 AM

The second fix doesn't work for me in polymost+classic

# if defined _M_AMD64 || defined _M_ARM64 || defined _M_X64 || defined _WIN64
typedef int64_t ssize_t;
# else
typedef int32_t ssize_t;
# endif

Hendricks266

Weaponized Autism

#1065 Posted 21 July 2017 - 08:41 AM

TON, on 21 July 2017 - 08:35 AM, said:

The second fix doesn't work for me in polymost+classic

Interesting, thank you for testing this for me.

icecoldduke

#1066 Posted 22 July 2017 - 06:13 AM

Hendricks I took the fix in my branch, that solved the Polymost and Classic render problem, but now I'm getting sector palettes not working right in Polymost(red sectors are not red for example). The only difference between Polymost sector palettes working and not working is /O2(Maximize Speed optimization).

This post has been edited by icecoldduke: 22 July 2017 - 06:18 AM

TON

#1067 Posted 23 July 2017 - 04:35 AM

icecoldduke, on 22 July 2017 - 06:13 AM, said:

Could you post screenshot with the problem?

I haven't that problem in windows 7 x64 and rev july16_2017

This post has been edited by TON: 23 July 2017 - 04:38 AM

icecoldduke

#1068 Posted 23 July 2017 - 07:38 AM

I have created a new website for my "ICED Shadow Warrior Port"(thanks to whoever in this topic that created the title

). You can find the latest binaries on my website https://crozzbreed23...site.com/icedsw Binaries will no longer be stored on github. I have also created a release branch, this branch is the stable branch. Release branch will always match 1:1 with binary releases. Master branch is my work branch. Things may not work in my work branch. If your compiling from code, and want the latest and greatest, use my master branch. If you want stable, go with my release branch. If you guys have github synced already, and you want release branch only, please switch over to the release branch.

TON, on 23 July 2017 - 04:35 AM, said:

I haven't that problem in windows 7 x64 and rev july16_2017

That problem isn't in the latest binary, I'm trying to reenabled compiler optimizations for the next binary release and its causing problems :thumbsup:

Forge

Speaker of the Outhouse

#1069 Posted 23 July 2017 - 09:01 AM

Added mouse button assignment yet?

icecoldduke

#1070 Posted 23 July 2017 - 09:11 AM

Forge, on 23 July 2017 - 09:01 AM, said:

Added mouse button assignment yet?

Yes about a week ago :thumbsup:

. Its in the latest binary.

This post has been edited by icecoldduke: 23 July 2017 - 09:11 AM

Forge

Speaker of the Outhouse

#1071 Posted 23 July 2017 - 09:27 AM

What do you need tested?

Still on my random summer schedule, so I'll be in and out for the next month - expect no consistency.

Master O

#1072 Posted 23 July 2017 - 09:54 AM

icecoldduke, on 23 July 2017 - 07:38 AM, said:

I have created a new website for my "ICED Shadow Warrior Port"(thanks to whoever in this topic that created the title

Your site says "ICED SW is running on Eduke32! Latest Binary: july212017 Engine: 20170605-6143."

I thought ICED SW was still unofficial?

Forge

Speaker of the Outhouse

#1073 Posted 23 July 2017 - 09:58 AM

The game's options menus are a bit sketchy & remain static when assigning values - you make a selection (e.g. assign a key or button), then escape back to the main menu and go back to the selection screen to verify the change was made -

also got a random crash in the 1st map of episode 1 (polymer) less than 2 minutes into it

icecoldduke

#1074 Posted 23 July 2017 - 09:59 AM

Master O, on 23 July 2017 - 09:54 AM, said:

I thought ICED SW was still unofficial?

Its very unofficial, if the verbage is confusing I need to fix that.

This post has been edited by icecoldduke: 23 July 2017 - 10:01 AM

icecoldduke

#1075 Posted 23 July 2017 - 10:00 AM

Forge, on 23 July 2017 - 09:58 AM, said:

also got a random crash in the 1st map of episode 1 (polymer) less than 2 minutes into it

What are your repo steps?

Hank

#1076 Posted 23 July 2017 - 10:07 AM

icecoldduke, on 23 July 2017 - 09:59 AM, said:

Its very unofficial, if the verbage is confusing I need to fix that.

It's clear to me. ICED SW is a port based on EDuke32.

It has its own name and can now not be confused with the ProAsm port

This post has been edited by Hank: 23 July 2017 - 10:13 AM

Ninjakitty

#1077 Posted 23 July 2017 - 10:23 AM

icecoldduke, on 23 July 2017 - 07:38 AM, said:

I have created a new website for my "ICED Shadow Warrior Port"(thanks to whoever in this topic that created the title

Love the new website!

Ninjakitty

#1078 Posted 23 July 2017 - 10:42 AM

Y'know, sooner or later, you're going to HAVE to add in physics/dropped items.
I'm guessing you just haven't gotten around to that yet.
But I keep running out of shurikens! :thumbsup:

Master O

#1079 Posted 23 July 2017 - 11:04 AM

icecoldduke, on 23 July 2017 - 09:59 AM, said:

Its very unofficial, if the verbiage is confusing I need to fix that.

I'd phrase it like this:

"ICED SW is an unofficial Shadow Warrior port based on EDuke32. Shadow Warrior is not officially supported by Eduke32 at this time."

icecoldduke

#1080 Posted 23 July 2017 - 11:35 AM

Master O, on 23 July 2017 - 11:04 AM, said:

"ICED SW is an unofficial Shadow Warrior port based on EDuke32. Shadow Warrior is not officially supported by Eduke32 at this time."

The latter part of that sentence is too wordy. The contact section takes into account that this project is not affiliated with duke4 or anything else.

This post has been edited by icecoldduke: 23 July 2017 - 11:39 AM