[Lightning_Hunter]

Well, I'm back (if anyone remembers me from the 3dRealms forums). Haven't played Duke3d in 5 years or more, so I'm catching up. I installed eduke32_win64_20160704-5811, Duke Plus, and HRP 5.4. I noticed that in Duke Plus, when the ejecting shells land on the ground, they spin (roll) indefinitely. Is there a way to fix this? I found this code, but am unsure what to change:

// action ANULLACTION 0

action SHELLROLLING -1 2 1 1 6
action SHELLSTOPPED -1 1 1 1 1

move SHELLROLL1 48
move SHELLBOUNCE 48 -20
move SHELLBOUNCE2 48
move SHELLROLL2	32
move SHELLROLL3 16
move SHELLSTOP

state shellcode
fall

setvar temp 0
ifvarg underwater 0 setvar temp 1
ifinwater setvar temp 1
ifvare temp 1
{
	ifmove SHELLSTOP nullop else
	{
		ifmove SHELLROLL3 nullop else
		move SHELLROLL3 geth
	}
}

Also, the shadows casted by monsters in Polymost mode look messed up. Any way to fix this?

[Danukem]

Welcome back! Unfortunately I have developed a serious mental hangup about maintaining DukePlus and haven't touched it in years, even though I have worked on other EDuke32 projects. I have seen the messed up shadows in Polymost when working on Duke Forces, so I know it's a general problem and isn't DukePlus related. With the shell casings...the CON code never changed for them and it used to work (that part you posted is only part of it). I am guessing that what used to be an idle tile number in the HRP has a spinning animation defined on it now, and that is what causes the problem.

LeoD has made a "nixfix" patch for DukePlus which fixes various issues -- the shell casings might be one of them, I'm not sure. I'll post a link to it if I can find it.

EDIT: Here is a link with several things that LeoD put together, scroll down for nixfix: https://forums.duke4...dpost__p__74887

[Lightning_Hunter]

 Trooper Dan, on 10 July 2016 - 04:09 PM, said:

LeoD has made a "nixfix" patch for DukePlus which fixes various issues -- the shell casings might be one of them, I'm not sure. I'll post a link to it if I can find it.

Thank you for this link. Unfortunately, it does not fix the shell bug. You are right that I did not post all the code. Any idea what is causing this issue?

Spoiler

// action ANULLACTION 0

action SHELLROLLING -1 2 1 1 6
action SHELLSTOPPED -1 1 1 1 1

move SHELLROLL1 48
move SHELLBOUNCE 48 -20
move SHELLBOUNCE2 48
move SHELLROLL2	32
move SHELLROLL3 16
move SHELLSTOP

state shellcode
fall

setvar temp 0
ifvarg underwater 0 setvar temp 1
ifinwater setvar temp 1
ifvare temp 1
{
	ifmove SHELLSTOP nullop else
	{
		ifmove SHELLROLL3 nullop else
		move SHELLROLL3 geth
	}
}

ifvare countvar 0
{
  setactor[THISACTOR].pitch 512
  clipdist 8
  setvar countvar 1
  getactor[THISACTOR].ang angvar
  randvar temp 256
  ifrnd 128 mulvar temp -1
  addvarvar angvar temp
  setactor[THISACTOR].ang angvar
  move SHELLBOUNCE geth getv
  ifactor 2534 // bullet shell
  {
	  action SHELLROLLING
	  ifrnd 128 sound SHELLFALL1 else sound SHELLFALL2
  }
  else // shotgun shell
  {
	  ifrnd 128 sound SHELLFALL3 else sound SHELLFALL4
  }
  resetcount
  cstat 384
}

ifmove SHELLBOUNCE ifcount 6
{
	move SHELLBOUNCE2 geth
	resetcount
}

ifmove SHELLBOUNCE2
{
	getactor[THISACTOR].zvel temp
	ifvarg temp 96 setactor[THISACTOR].zvel 96
	setvar tempb 0
	iffloordistl 1 setvar tempb 1
	ifcount 8 setvar tempb 1
	ifvare tempb 1
	{
		ifrnd 128 move SHELLROLL2 geth else
	  	move SHELLROLL1 geth
	  	ifactor 3509 { ifmove SHELLROLL1 move SHELLROLL2 geth else move SHELLROLL3 geth }
	    resetcount
    }
}


ifmove SHELLROLL1 ifcount 22 { move SHELLROLL2 geth resetcount }
ifmove SHELLROLL2 ifcount 16 { move SHELLROLL3 geth resetcount }
ifmove SHELLROLL3 
  ifcount 12
    ifrnd 32 
{
	 setactor[THISACTOR].mdflags 2
     move SHELLSTOP
     ifactor 2534 action SHELLSTOPPED
     ifrnd 128 cstat 388
     
     getflorzofslope sprite[THISACTOR].sectnum sprite[THISACTOR].x sprite[THISACTOR].y z // z is the return var
     setactor[THISACTOR].z z
}

ifnotmoving
{
	getactor[THISACTOR].ang angvar
	addvar angvar 1024
	randvar temp 256
	ifrnd 128 mulvar temp -1
	addvarvar angvar temp
	setactor[THISACTOR].ang angvar
}

ifhitweapon
{
	getactor[THISACTOR].htang angvar
	ifactor 2534 espawn SHELL else
	espawn SHOTGUNSHELL
	setactor[RETURN].ang angvar
	randvar temp 32
	addvar temp 96
	setactor[RETURN].xvel temp
	killit
}

ifspawnedby APLAYER { ifcount 1560 killit }
else
ifcount 260 killit

ends

[Danukem]

 Lightning_Hunter, on 10 July 2016 - 10:11 PM, said:

Thank you for this link. Unfortunately, it does not fix the shell bug. You are right that I did not post all the code. Any idea what is causing this issue?

 Trooper Dan, on 10 July 2016 - 04:09 PM, said:

With the shell casings...the CON code never changed for them and it used to work. I am guessing that what used to be an idle tile number in the HRP has a spinning animation defined on it now, and that is what causes the problem.

The code you found isn't responsible for the spinning on the ground. The shell casings are supposed to rotate while in the air (before that code kicks in). Once on the ground, they get a random angle one time and then roll, and maybe bounce and knock into stuff, which is what that code handles.

[Lightning_Hunter]

Ah, well sorry about that. I don't see anything else related to the shells in the code, so I must be missing something.

[Fantinaikos]

 Lightning_Hunter, on 11 July 2016 - 09:17 AM, said:

Ah, well sorry about that. I don't see anything else related to the shells in the code, so I must be missing something.

For your problem you must search into the dukeplus.def, not into the .con's, you must change the bullets frame animations.

"Gun shells"

model "DUKEPLUS_RESOURCES/GRAPHICS/shell.md3" {
scale 5 shade 5
skin { pal 0 file "DUKEPLUS_RESOURCES/GRAPHICS/shell.png" }
anim { frame0 "FRAME2" frame1 "FRAME10" fps 40 flag 0 }
anim { frame0 "FRAME11" frame1 "FRAME16" fps 30 flag 1 }
frame { name "FRAME2" tile0 2533 tile1 2534 }

}

"Shotgun shells"

model "DUKEPLUS_RESOURCES/GRAPHICS/shell.md3" {
scale 7 shade 5
skin { pal 0 file "DUKEPLUS_RESOURCES/GRAPHICS/shell2.png" }
anim { frame0 "FRAME2" frame1 "FRAME10" fps 40 flag 0 }
anim { frame0 "FRAME11" frame1 "FRAME16" fps 30 flag 1 }
frame { name "FRAME2" tile 2535 }
frame { name "FRAME2" tile 6325 }

}

These are JUST INDICATIONS where the lines are, not replacement. I found the solution to this in another mod but I'm not sure that can be applied to Dukeplus too.

[Danukem]

 Fantinaikos, on 11 July 2016 - 11:06 AM, said:

For your problem you must search into the dukeplus.def, not into the .con's, you must change the bullets frame animations.

Actually, no. It would be even simpler to just disable model animation when the shell hits the ground.

So, in the state "state shellcode" just add the line "setactor[THISACTOR].mdflags 2"

[Fantinaikos]

Even with this method the bullets, once hit the ground, roll away until stops instead of spinning?

[Danukem]

 Fantinaikos, on 11 July 2016 - 11:47 AM, said:

Even with this method the bullets, once hit the ground, roll away until stops instead of spinning?

You can see from the code posted above that they were never intended to spin on the ground (even though that may have been nice, if done in moderation).

The code that makes them move uses the good old move command, which makes sprites go in the direction of their angle. Spinning the model without an animation would constantly change the angle, so that wouldn't work (with the current code).

[Lightning_Hunter]

If all else fails, I wouldn't mind if someone just told me how to stop the spinning altogether with the shells.

[Danukem]

 Lightning_Hunter, on 11 July 2016 - 12:52 PM, said:

If all else fails, I wouldn't mind if someone just told me how to stop the spinning altogether with the shells.

So, now that I'm actually working on it, I notice that I already had the mdflags 2 set in part of my code, which used to successfully stop the shells from spinning. Now I'm wondering if mdflags is broken in EDuke32. EDIT: Yeah setting mdflags to 2 on the sprites does not stop the animation like it is supposed to. I checked in both polymer and polymost. The flag isn't completely broken, though. If I set mdflags 2 on all sprites (in EVENT_GAME) animation does stop on other models. But for some reason it doesn't work on the shells.