[Zagro]

I noticed eduke32 builds clean, except source/net.c that shows the following warnings, that seems easy enough to silence, is it only for me?

source/net.c: In function ‘Net_ParseServerPacket’:
source/net.c:597:14: warning: unused variable ‘nsyn’ [-Wunused-variable]
source/net.c:596:19: warning: unused variable ‘l’ [-Wunused-variable]
source/net.c:596:16: warning: unused variable ‘j’ [-Wunused-variable]
source/net.c:596:13: warning: unused variable ‘i’ [-Wunused-variable]
source/net.c: In function ‘Net_ParsePacketCommon’:
source/net.c:677:16: warning: unused variable ‘j’ [-Wunused-variable]
source/net.c:677:13: warning: unused variable ‘i’ [-Wunused-variable]
source/net.c: In function ‘Net_RecieveVersion’:
source/net.c:736:48: warning: unused parameter ‘packbufleng’ [-Wunused-parameter]
source/net.c: In function ‘Net_RecieveChallenge’:
source/net.c:772:50: warning: unused parameter ‘packbufleng’ [-Wunused-parameter]
source/net.c: In function ‘Net_RecieveNewPlayer’:
source/net.c:802:50: warning: unused parameter ‘packbufleng’ [-Wunused-parameter]
source/net.c: In function ‘Net_RecievePlayerIndex’:
source/net.c:855:52: warning: unused parameter ‘packbufleng’ [-Wunused-parameter]
source/net.c: In function ‘Net_SendMapUpdate’:
source/net.c:1018:14: warning: unused variable ‘prevMapDiff’ [-Wunused-variable]
source/net.c:1015:14: warning: unused variable ‘numdiff’ [-Wunused-variable]
source/net.c: In function ‘Net_FillMapDiff’:
source/net.c:1149:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
source/net.c:1149:56: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
source/net.c:1153:45: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
source/net.c:1154:41: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
source/net.c: In function ‘Net_RestoreMapState’:
source/net.c:1213:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
source/net.c:1230:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
source/net.c: In function ‘Net_ReceiveServerUpdate’:
source/net.c:1586:12: warning: unused variable ‘numupdates’ [-Wunused-variable]
source/net.c: In function ‘Net_SendMapVoteInitiate’:
source/net.c:2005:13: warning: unused variable ‘i’ [-Wunused-variable]
source/net.c: In function ‘Net_SendMapVoteCancel’:
source/net.c:2150:13: warning: unused variable ‘i’ [-Wunused-variable]
source/net.c: In function ‘Net_RecieveMapVoteCancel’:
source/net.c:2181:16: warning: unused variable ‘numvotes’ [-Wunused-variable]
source/net.c:2181:13: warning: unused variable ‘i’ [-Wunused-variable]

[Plagman]

No, everyone gets these, including the automated builder, so I get daily email about these. Thing is, these days the netcode is worked on by someone who works out of tree and sends patches, so we try to minimize conflicts by not changing it under his foot too much. I agree that otherwise it'd be trivial to fix.

[Hendricks266]

Most of these (the unused parameters and unused variables) could be for things he has planned but not yet implemented and removing them would make life more difficult for him. Once he is "done" we'll clean it up for sure.