[deuxsonic]

As of r5108, trying to save or load a savegame causes the game to crash without error.

Attached File(s)

•  eduke32.log (1.92K)
  Number of downloads: 181

[LeoD]

deuxsonic, on 28 March 2015 - 06:57 AM, said:

As of r5108, trying to save or load a savegame causes the game to crash without error.

Actually introduced between r5071 and r5081.

Attached File(s)

•  eduke32.crash-5081.log (2.5K)
  Number of downloads: 188

[deuxsonic]

Fair enough, I just happened to catch it when I updated this time.

[Hendricks266]

I've reproduced the savegame crash on my end.

[Hendricks266]

Could you test if synthesis build r5112 fixes the problem?

[deuxsonic]

Hendricks266, on 28 March 2015 - 06:51 PM, said:

Could you test if synthesis build r5112 fixes the problem?

That seems to fix it.

However, any save games made using the affected builds will crash the game as follows:

rsd: spec=blK:scri, idx=12, mem=1397E9B8
(compressed): read -1, expected 12087!
read: Invalid argument
sv_loadsnapshot: doloadplayer2() returned -5.
Loading save game file "dukesav0.esv" failed (code 5), cannot recover.

[Hendricks266]

That is necessary due how I addressed the problem; all savegames produced by the builds in question were faulty. It was by a fluke in other code that the circumstances that triggered the crash on saving only happened sometimes instead of consistently. I chose to clean up a mess, rather than work around it.

Spoiler

In theory, you could recover them by editing them in a hex editor, but the trouble is that you would need to know where the beginning of ProjectileData[] is, and it is different in every savegame with no clear indication of where it is other than once the savegame parser itself has read all the previous data whose order is defined in the code only and whose size varies based on factors like the map size and number of sprites present in the game world.

1. Go to address 0x????????.
2. Read the first two bytes there as a signed little-endian 16-bit integer.
3. Seek past the two bytes the amount that they contained.
4. Repeat steps 2 and 3 once.
5. Delete the region from the starting address to the point you are now at.
6. Save.

How important are these saves to you? The amount of work needed to recover them remotely (via a tool or modifying EDuke32) does not seem worth my time as a developer. If they are important, it would be easiest for you to send them to me and for me to make the changes myself.

[deuxsonic]

They're not that important as the saved game version gets bumped frequently as it is and being limited to 10 save games to a folder means frequently having to overwrite my own saves. With unlimited saves then keeping the saves would be more important.